Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapper overwrites gameslist.xml and not appending to it on windows. #19

Open
e-shapsough opened this issue Aug 4, 2018 · 8 comments

Comments

@e-shapsough
Copy link

Scrapper gets the images and the info correctly, stores them in the right folder, but it overwrites the xml file sort of random and when restarting emulation station not all games info/images show.

@PittStone
Copy link

I made all my xml files to "read only" after scrapping with the right folders. I have the same Problem, if not "read only", emulationstation overwrites sometimes my locations and its not portable anymore.

@e-shapsough
Copy link
Author

with me it overwrites while scrapping, changes do not show until emulationstation is restarted

@altiereslima
Copy link

Sometimes some games disappear on my EmulationStation.

@FernandoCarvalho155
Copy link

It overwrites the xml file, I tested a simple 4 games system and i got:

4 games in ROM rolder:

original Gamelist:

Game 1 > Scrapped
Game 3 > Scrapped
Game 4 > Scrapped

Game 2 Unscrapper, not in Gamelist

When you run the Scrapper, Emulationstation find the data and image for Game 2 but the new gamelist

Game 1 > Scrapped
Game 3 > Scrapped
Game 2 > Scrapped

Game 4 was overwrited and is not in the gamelist anymore.

@c0d3Art1st
Copy link

I can confirm this problem.
Oddly, in my case this only happens if the games to be scraped are not zipped.
If I zip the games, the updated gamelist.xml persists and nothing is changed or randomly deleted when I start ES afterwards again.
But when I scrape a bunch of unzipped games (eg. bin-files), exit ES and start ES again, some among these games suddenly miss the scraped info.
Seems the only temporary fix is to make the gamelist.xml read-only after the initial scraping :-/

I hope this bug will be fixed in a future release :-)

@hanger85
Copy link

hanger85 commented Nov 5, 2018

EDIT: That seemed to fix my issue, but it does seem odd that files need to be a zip rather then their native extension.

I have this issue as well. I'll scrape games and verify artwork and names are correct. After exiting and reentering some images are gone, but they are still in the image folder. Some games will also change their name and when i view the gamelist xml i can see where their display names have been changed. I'll have 6 copies of mega man 5 because all the other mega man games change their name. This was apparently fixed in the pi versions already.

@altiereslima
Copy link

In my case this only happens if the games to be scraped are not zipped.

@herebcs
Copy link

herebcs commented Dec 24, 2018

I submitted a PR that may fix these issues. Please look at RetroPie#512.

fabricecaruso pushed a commit to fabricecaruso/old-EmulationStation-fork---see-batocera-emulationstation-instead that referenced this issue Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants