Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing multiple og:image elements #32

Open
ceir opened this issue Jul 15, 2022 · 1 comment
Open

Allowing multiple og:image elements #32

ceir opened this issue Jul 15, 2022 · 1 comment

Comments

@ceir
Copy link

ceir commented Jul 15, 2022

Defining multiple tags with the same keys can be useful. In the case of "og:image" Facebook sharing (and prehaps other SEO parsers) will take all the elements and attach all the images to the post.

Currently a code like this:

<Meta Property="og:image" Content="https://img1" />
<Meta Property="og:image" Content="https://img2" />

Will leave the header with only a single - using just the value from the latest declaration (in this case with value "https://img2". Adding the option to have multiple items of the same sort would be useful.

@jsakamoto
Copy link
Owner

@ceir Thank you for your proposal!
Well, your proposal makes sense, so I'll try to implement the ability to allow multiple tags with duplicate keys.
However, it must not be easy on the current architecture of this library. It has to make big changes to this library to realize it. It must take a long time. Moreover, I can not spend much time maintaining this library because this is my weekend hobby product, so I'll appreciate it if you are patient, even if it takes a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants