Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong inner product cost in list_decoding #1

Open
jschanck opened this issue Apr 12, 2022 · 0 comments
Open

Wrong inner product cost in list_decoding #1

jschanck opened this issue Apr 12, 2022 · 0 comments

Comments

@jschanck
Copy link
Owner

The value of ip_cost in the list_decoding function of cost.py is for a dimension d inner product on 32-bit integers. It should be for a dimension d/log(d) inner product. This gives us the wrong value for insert_cost and query_cost here:

eprint-2019-1161/cost.py

Lines 783 to 784 in 09d72d2

insert_cost = filters * C(d, T2) * ip_cost * log2(d) # Alg 4, Line 5
query_cost = filters * C(d, T1) * ip_cost * log2(d) # Alg 4, Line 8

Thanks to Leo Ducas for reporting this error (https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/Fm4cDfsx65s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant