Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I implement Typescript? #98

Open
dugiwarc opened this issue Jun 27, 2020 · 6 comments
Open

How do I implement Typescript? #98

dugiwarc opened this issue Jun 27, 2020 · 6 comments

Comments

@dugiwarc
Copy link

Would the current setup be compatible with Typescript?

@pronebird
Copy link
Collaborator

pronebird commented Jun 27, 2020

Hi,

It's possible to adapt it for TypeScript. The project I work on is in TypeScript so we've modified the scripts to add support for TypeScript and it's open source too, see:

  1. https://github.com/mullvad/mullvadvpn-app/blob/efd09e63dcdad21ce2d3cc6df2f6d56818684586/gui/tasks/scripts.js
  2. https://github.com/mullvad/mullvadvpn-app/blob/efd09e63dcdad21ce2d3cc6df2f6d56818684586/gui/tasks/watch.js#L46-L61

We have people coming with different requirements and it's truly difficult to satisfy everyone and at the same time keep the boilerplate minimal. Perhaps we should add codeshift or git patches to reconfigure this boilerplate for whatever needs people have. My only concern that at some point it will be a disaster to maintain.

Any thoughts on this @jschr?

@jschr
Copy link
Owner

jschr commented Jun 28, 2020

Thanks for TS examples @pronebird. If you feel like they would be helpful to link in the README then feel free to add!

I agree, it's not feasible to maintain this boilerplate for all the different libs people want to use and is meant to be a good starting point for most users. I like the codeshift idea but I share the same concerns if we have a lot of them.

@pronebird
Copy link
Collaborator

@jschr if I ever have extra hour, I think I could backport support for TS to this boilerplate in a separate branch which we could rebase over master from time to time.

@jschr
Copy link
Owner

jschr commented Dec 8, 2022

@pronebird that sounds good to me! I'd be happy to transfer this repo over to you as well since I haven't had much time to keep up with it.

@pronebird
Copy link
Collaborator

@jschr up to you. I really don't mean to take it from you as you were the one who started it. I can remain a collaborator even if you're not active any longer.

@jschr
Copy link
Owner

jschr commented Dec 19, 2022

@pronebird Honestly, up to you 😄

You've put in more work into this repo as I have by now so I'm more than happy to see it live elsewhere if that's the best thing to do for users stumbling about this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants