Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mime type for DCM format #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darshitmaniar
Copy link

Kindly update this block

@darshitmaniar darshitmaniar changed the title Allow DCM format Update mime type for DCM format Feb 16, 2023
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for your contribution! You cannot modify the db.json file directly, as it is a generated file and changes you make will be overwritten. Please see contribution instructions at https://github.com/jshttp/mime-db#contributing . When you update the custom file, please include the source of your information, which should clearly state the extension is for this mime type and not be a prohibited site. Thank you!

@darshitmaniar
Copy link
Author

Thanks for the reply, update the custom-types.json file as per instructions.

src/custom-types.json Outdated Show resolved Hide resolved
@dougwilson dougwilson added the pr label Feb 17, 2023
@@ -501,6 +501,12 @@
"application/zip": {
"compressible": false
},
"application/dicom": {
"source": [
"https://en.wikipedia.org/wiki/DICOM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a link to a primary source; Wikipedia is even specifically called out as not acceptable in the README: https://github.com/jshttp/mime-db#direct-inclusion

Copy link

@DimitriPapadopoulos DimitriPapadopoulos Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See instead:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, "application/dicom" is already present in src/iana-types.json:

mime-db/src/iana-types.json

Lines 607 to 612 in a76e5a8

"application/dicom": {
"sources": [
"https://tools.ietf.org/rfc/rfc3240.txt",
"https://www.iana.org/assignments/media-types/application/dicom"
]
},

You should probably add "extensions": ["dcm"] at the above location, like #295.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants