Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mime type for DCM format #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update mime type for DCM format #287

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
801aa6b
Allow DCM format
troodarshitmaniar Feb 16, 2023
bb96226
update types file for dicom format
troodarshitmaniar Feb 17, 2023
7085c07
update source
troodarshitmaniar Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/custom-types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,12 @@
"application/zip": {
"compressible": false
},
"application/dicom": {
"source": [
"https://en.wikipedia.org/wiki/DICOM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a link to a primary source; Wikipedia is even specifically called out as not acceptable in the README: https://github.com/jshttp/mime-db#direct-inclusion

Copy link

@DimitriPapadopoulos DimitriPapadopoulos Jul 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See instead:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, "application/dicom" is already present in src/iana-types.json:

mime-db/src/iana-types.json

Lines 607 to 612 in a76e5a8

"application/dicom": {
"sources": [
"https://tools.ietf.org/rfc/rfc3240.txt",
"https://www.iana.org/assignments/media-types/application/dicom"
]
},

You should probably add "extensions": ["dcm"] at the above location, like #295.

],
"extensions": ["dcm"]
},
"audio/3gpp": {
"compressible": false,
"extensions": ["3gpp"]
Expand Down