Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iana-types.json #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pzsette
Copy link

@pzsette pzsette commented Jun 15, 2023

Add 'dcm' extension to application/dicom mime. 'dcm' is the recommended extension for this multimedia type as stated at point 2 of additional information in this iana.org page https://www.iana.org/assignments/media-types/application/dicom.

add 'dcm' extension to application/dicom mime
@DimitriPapadopoulos
Copy link

DimitriPapadopoulos commented Jul 31, 2023

Partial duplicate of #287. This is the correct fix, prefer it over #287.

@pzsette
Copy link
Author

pzsette commented Aug 3, 2023

@DimitriPapadopoulos How long does it take to approve the pull request?

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for your contribution. Unfortunately the file you changed is a generated file and your changes would be overridden. Please see our contribution instructions at https://github.com/jshttp/mime-db#direct-inclusion

@dougwilson
Copy link
Contributor

Sorry, I thought I already commented on it, but apparently I never submitted the comment. The PR needs to be updated to change a non generated file.

@dougwilson dougwilson added the pr label Aug 3, 2023
@DimitriPapadopoulos
Copy link

@dougwilson So #287 is the correct fix after all, with "application/dicom" split between src/iana-types.json for the part extracted as is from the IANA database, and the addition in src/custom-types.json?

Shouldn't the IANA database be fixed upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants