New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests for Node@8 and Node@9 #122

Closed

carpasse opened this issue Mar 25, 2024 · 0 comments · Fixed by #123

Contributor

carpasse commented Mar 25, 2024

Seems like the current master branch have some broken tests when running Node@8 and Node@9. @UlisesGascon notice that with the PR: #121.

Similar error in both cases: https://github.com/jshttp/mime-types/actions/runs/8278038868/job/22655381584#step:10:15, here is an screenshot in case that you can't access to the logs:

It seems to be the same issue we had in http-errors

jonchurch mentioned this issue

Fix Node 8 and 9 tests, pin nyc version used for testing in Node 9 and 8 #123

Merged

UlisesGascon closed this as completed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment