Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow v2 model support #100

Open
Petros626 opened this issue May 25, 2022 · 6 comments
Open

tensorflow v2 model support #100

Petros626 opened this issue May 25, 2022 · 6 comments
Labels
question Further information is requested

Comments

@Petros626
Copy link

Hey,

I've read that only ssd models are supported for TFLite1 and TFLite2, so the hardware accelerator (Edge TPU) supports only ssd models until now. I saw that in the example the ssd_mobilenet_v2 i used for inference. But would the newer one (SSD MobileNet V2 FPNLite 640x640) of TensorFlow 2 also with this node?

@knorth55
Copy link
Member

knorth55 commented May 25, 2022

Only tflite1 is supported, I think.
Ive never tried tensorflow v2 before.

@Petros626
Copy link
Author

Okay thank you. So you dont know it 100%. Is there the option to ask the guy, who added the support for ssd_mobilenet_v2?

@knorth55
Copy link
Member

Sorry, but I dont understand your question.
Mobilenet V2 is the model name, and it doesnt mean the model is for tensorflow 2

@Petros626
Copy link
Author

Ok maybe I explain it wrong. The user: Kanazawanaoaki added: "Add ssd to bounding box sample" to the jsk_recognition package right? So this is implemented in this package, because you said it's connected?

The other point was, that the model: ssd_mobilenet_v2 is only supported by TensorFlow 1 and the newer one (I asked for) SSD MobileNet V2 FPNLite only by TensorFlow 2. The question is, if I try to run your node with a tflite model, which bases on the newer one would it be compatible or I must stick to the ssd model from TensorFlow 1 :)

@knorth55 knorth55 added the question Further information is requested label May 25, 2022
@knorth55
Copy link
Member

knorth55 commented May 25, 2022

I understood.

I wrote almost whole part of this repo (you can check it in commit log), and, at that time, tensorflow2 is not common.
So I wrote in tensorflow1, and all models are in tensorflow1.
If you want to use tensorflow2 model, I have no idea.
Please try by yourself first.
If there is no backward compatibility, you need to change this repo's code or hate tensorflow because of the lack of backward compatibility.

This is open source repo, and not a product.
I will help you some but I want you to help us, too.
If I need to use tensorflow2 model, I will implement, but there is no need in my lab now, so I won't do it soon.

Do not hesitate to change the code. Please open a pull request.
Do not completely expect to or rely on others' work.
Now you get a chance to learn tensorflow2.

@Petros626
Copy link
Author

Yeah thank you for the detailed explanation, if I have the time I would do so, but I'm working on my bachelor degree, so for first use it should only run on TensorFlow 1 model.

Hahah I think the guys from TensorFlow do their best :D

@knorth55 knorth55 changed the title tensorflow model support tensorflow v2 model support Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants