-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current state of this project #14
Comments
@JulianCataldo I see some areas for improvement (more automation, improved build process) but I'm curious about where you want to go? I agree that focusing on the core library is what is essential. UI flavors should be left up to individual devs or community updates. |
Hello @pgoforth, I'll get some time 3 months or so, in the meanwhile, I could give you a maintainer role for the org., and I'll just do a quick review for the novelties before including them, what do you think? Here is the basic stuff that I wanted to sort out before I paused this project:
There is more, especially regarding UI Schemas, I'll post later on this, because it's a central concern. Cya |
Regarding the testing side, I've experimented with open-wc web test runner for custom elements mounting points, lit-ssr (for, well, testing SSR capabilities), Gracile (for convenience) and Playwright (for more intricate stuff, like hydration compliance). |
So, I'm prefacing this all by saying my time to devote to OS projects is very limited, and I will most likely be working on things that would directly benefit my usage of the library. That said, I'm happy to contribute and try to address these issues along the way. Perhaps I can give some insight into this process based on how I am currently using this library. I am only using the base In regards to augmenting the form schema, I actually built a form builder schema myself a couple years ago, and I can see a lot of ideas I implemented there that would be useful to this project (dependent fields, data referencing, things like that). I will go through my schema and highlight some ideas and give examples as I get the time. TestingIMO there are many levels of testing that need to happen, not just the UI or Integration level tests that you refrence. I bring this up because (in my experience) web components (and by proxy custom elements) are in their infancy with testing libraries, and you should not solely rely on these kinds of tests. I would suggest starting with:
ToolingI'm still not getting everything working properly in my VSCode in regrads to module name resolutions (seems to really have issues with the |
Wow. Thanks for your insights! Definitely some valuable ideas here. For the CSS workflow, user do their choice here, like you did, or like I did for the vendor UI libs widgets. No worries for the time you can offer, it's OSS, purely based on volunteering. I'm not asking anything, because I do this by pure passion, I expect that if people want specific stuff, they should invest in a commercial support, or bounties or whatever… ;) But this project is not big enough for that anyway. I don't have strong opinions on the UI schema side of things, except that I found the RJSF way of things is the most flexible I've found for this kind of libs. The workspace issue you had doesn't ring a bell for me. It is supposed to work well without much fiddling, thanks to PNPM workspace management. |
Yeah, I resolved the workspaces issue by manually installing deps inside each package folder. Edit:
|
Never seen this Only https://rjsf-team.github.io/react-jsonschema-form/docs/json-schema/dependencies/ is known to me. |
The I'm floating it as an idea for customization beyond JSON Schema that would be appropriate for this product. |
Very impressed by this product. It's useful to me because I have made an intentional choice to simplify my stack. My product is entirely golang on the back end with alpine and htmx on the front end. Very very little JavaScript but I do need forms like you have here. I still need to download it and tinker with it from contributor perspective, but curious what level of openness there would be to adding me as a contributor to be able to self-manage if I run into bugs that need fixing? Not promising anything yet, but I'm impressed with what I see Also, if you're able to be blunt with me, is there anything in particular I should pay close attention to that you feel is rough around the edges or unfinished? |
I accept PRs and Issues, but I don't currently have time to review them swiftly.
I got some ideas to make this lib more SSR friendly, more headless, etc. so I'll will do everything in one sweep at that moment.
Note that I only maintain the core (headless) lib, not the UI implementations, which are up to you to customize. But PRs are welcome, of course.
Feel free to show your support if you think this project can evolve into something more professional, with more advanced features ;)
And don't forget it is not a production-ready project!
The text was updated successfully, but these errors were encountered: