-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to vanilla js #252
Comments
@jsor Any plans to migrate to vanilla js? 👍 |
@jsor +1 👍 |
So, is anyone doing this? Should we just start? :) (There is also the great https://youmightnotneedjquery.com/ btw) |
@naton Don't think so go ahead and do it, I will be the first one to swap :) |
OK, here's a shot: https://github.com/naton/lity/tree/vanilla_js
|
@wpsumo Did you get a chance to try it out yet? I'm confident enough to merge it into my master now, and then do a PR here, if that's of interest. |
Anyway, I opened up a PR for this. Let me know if it should be based on another branch than master or if there's anything else I should do. |
@naton Sorry missed your comment, no I just saw it haven't had a chance to test it out yet. Let me test it next week and get back to you. I will test it within wordpress with data-lity-target on the img tag. I will let you know how it goes within wordpress and defer and delay loading of javascript/s.
|
Just tested it with the code below, works perfectly, thanks a lot @naton ! |
@naton Since this project doesn't seem to be maintained anymore (last PR merged was Dec 22, 2020), can we all move to your fork? |
@naton would make sense to do that based on @ojvribeiro comment above. Lets all move to your fork and continue using lity. I've not tested it yet, sorry about that, it's about time to do it! I'll let you know :D |
Feel free to! I can't promise anything but since I use it myself I'll fix bugs as I find them. |
Move from jQuery dependencies to vanilla js:
https://wpspeedmatters.com/jquery-performance/
The text was updated successfully, but these errors were encountered: