Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate .d.ts instead of .ts #252

Closed
tjx666 opened this issue Mar 7, 2023 · 3 comments · Fixed by #257
Closed

generate .d.ts instead of .ts #252

tjx666 opened this issue Mar 7, 2023 · 3 comments · Fixed by #257
Assignees
@Bubblyworld
Labels
bug Something isn't working

Comments

@tjx666
Copy link

tjx666 commented Mar 7, 2023 •
edited
Loading

reproduce:

  1. git clone https://github.com/tjx666/wpm-issue
  2. pnpm install
  3. tsc

image
@Bubblyworld
Copy link
Contributor

Related to #234, these are actual typing issues in the generator (we don't have strict typing enabled, should get on that!).

@RyanCavanaugh
Copy link

FYI: this is a critical misconfiguration. The types field cannot point to a .ts file; this is going to effectively break any TypeScript consumer of the package.

@Bubblyworld Bubblyworld self-assigned this Mar 8, 2023
@Bubblyworld Bubblyworld added the bug Something isn't working label Mar 8, 2023
This was referenced Mar 8, 2023
Merged
Closed
@Bubblyworld
Copy link
Contributor

Ah, ok, thanks! I see what the issue is now - posted a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bubblyworld Bubblyworld

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: generate type declaration files and map to them in package.json Bubblyworld/generator
3 participants
@Bubblyworld @RyanCavanaugh @tjx666