Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classloading / Clarify Spec #358

Open
cruftex opened this issue Jun 6, 2016 · 3 comments
Open

Classloading / Clarify Spec #358

cruftex opened this issue Jun 6, 2016 · 3 comments
Assignees
Milestone

Comments

@cruftex
Copy link
Member

cruftex commented Jun 6, 2016

Umbrella ticket for classloading. Should serve for general discussion on the topic and link to the tickets of the detail changes.

In general, the spec says on page 17:

2.5. Execution Context
EntryProcessors, CacheEntryListeners, CacheLoaders, CacheWriters and
ExpiryPolicys (“customizations”) are instantiated and operate in the context of the CacheManager
URI and ClassLoader in which they were configured. This means at deployment time, instances of
these customizations must be available to and have access to application classes defined by the
ClassLoader for a Cache.

TODO:

  • General clarification, e.g. "deployment time" probably means "runtime".
  • Reflect issues we found and addressed in MR 1.1
  • Check appearances of classloader in the API and make it consistent
@cruftex cruftex added this to the 1.1 milestone Jun 6, 2016
@cruftex cruftex self-assigned this Jun 6, 2016
@OndroMih
Copy link

Do we have any progress / agreement on this? I would be happy to know if I can help somehow.

@cruftex
Copy link
Member Author

cruftex commented Sep 30, 2016

Hi Ondrej,

I have some reasonable ideas for the places I found so far, that need clarification and corrections. However, whether this fits for all scenarios (OSGi and EE) needs good testing. Furthermore, I am not sure whether I found all places that are affected by classloading issues so far.

How to help:

  • Make a list of all API elements that are affected by classloading (and needs tests regarding this)
  • Use cases and tests!
  • Besides, reviewing my currently pending other PRs and give +1s would be good help, too. Those should be merged, before doing more or bigger changes, otherwise its lots of extra work for the re-basing.

I will set aside one week in November to do some more work on 1.1 and plan to produce a PR on every currently remaining issue.

BTW: Saw your other activity on the ML and will comment next, when I am back from vacation :)

@gregrluck
Copy link
Member

Deployment and deployment time is a term used widely in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants