Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3book #33

Open
9 of 11 tasks
JasonSqz opened this issue Apr 19, 2022 · 5 comments
Open
9 of 11 tasks

d3book #33

JasonSqz opened this issue Apr 19, 2022 · 5 comments

Comments

@JasonSqz
Copy link
Contributor

JasonSqz commented Apr 19, 2022

  • section 0.1.2 a bit unclear how to hide the sidebar, maybe say it's on the top bar of the page.

  • section 1.1 downloading the repo is a bit overkill. I think we can just open the page -> right click -> save as -> add .html

  • section 2.3 extra `

  • section 3.2.3 maybe could explain a bit why the graphs can be interactive.

  • section 3.3.1 maybe add a link to download five_green_circles.html again.

  • section 3.5 I did not realize stroke is an attr and used append() first.

  • section 3.5 Upon looking at the solution, I think both .attr("stroke-width", "5") and .attr("stroke-width", 5) works.

  • section 3.7 I think it's more coherent to move that to section 4

  • section 4.3 I refreshed the page for the next section and svg is no longer defined.

  • section 4.8 Maybe add a little bit more explanation.

  • section 5.3.1 inconsistency in var and let

Went through all sections until section 6.

@anniechencan
Copy link
Contributor

anniechencan commented Apr 20, 2022

  • For each exercise with solutions, maybe add a link directly to the page of solutions in section 15; Also add the exercise numbers in section '15 Solutions' to make it easier to find and try.

  • For the solution 'Update, Enter, and Exit: vertical bar chart' in section 15, the answer shown in the book down is inconsistent with that in the given link.

  • For section 5.3.1, the annotation inside the chunk is confusing: which is for R and which is for JavaScript? ; using '#' in the chunk makes it hard to direct copy and paste JavaScript codes

@JasonSqz
Copy link
Contributor Author

JasonSqz commented Apr 25, 2022

  • section 6, maybe change some of the section into exercise. (Possibly all sections and provide some guidance) i think this is a really import section and scaling is not very easy to understand (Need to do it instead of looking at codes).
  • I think one of the problem after section 5 is the lack of explanations. It's fine if someone is following along with the lecture recording. However, for those who do not have access to the recording, it might bring some confusion.

@anniechencan
Copy link
Contributor

Same opinion as Jason on section 6, and instead of directly giving an HTML code to download, it's better to provide instructions that can be interactive on the page, just similar to the format in section 4.9.

@anniechencan
Copy link
Contributor

anniechencan commented Apr 26, 2022

  • For section 11.4 Blockbuilder 2015-2020, the link direct to Mike Bostock shows that the author no longer maintains the codes on Blockbuilder and instead moves all of the resources to Observable. So not sure whether still keep this part.

  • Section 14.1, the second link “So you’ve been asked to make a reprex” no longer avaliable.

@jtr13
Copy link
Owner

jtr13 commented Apr 27, 2022

Add check marks so we can indicate which issues were addressed in pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants