-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3book #33
Comments
|
|
Same opinion as Jason on section 6, and instead of directly giving an HTML code to download, it's better to provide instructions that can be interactive on the page, just similar to the format in section 4.9. |
|
Add check marks so we can indicate which issues were addressed in pull requests. |
section 0.1.2 a bit unclear how to hide the sidebar, maybe say it's on the top bar of the page.
section 1.1 downloading the repo is a bit overkill. I think we can just open the page -> right click -> save as -> add .html
section 2.3 extra `
section 3.2.3 maybe could explain a bit why the graphs can be interactive.
section 3.3.1 maybe add a link to download
five_green_circles.html again
.section 3.5 I did not realize stroke is an
attr
and usedappend()
first.section 3.5 Upon looking at the solution, I think both .attr("stroke-width", "5") and .attr("stroke-width", 5) works.
section 3.7 I think it's more coherent to move that to section 4
section 4.3 I refreshed the page for the next section and svg is no longer defined.
section 4.8 Maybe add a little bit more explanation.
section 5.3.1 inconsistency in
var
andlet
Went through all sections until section 6.
The text was updated successfully, but these errors were encountered: