You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
karabiner-driverkit uses sw_vers command at runtime for macos which leads to not being reproducible and build can fail in sandboxed environments.
I've already created an issue on karabiner-driverkit repo (relevant issue).
This is problematic for systems like nix. (see relevant comment, )
Proposed solution
Not relying in runtime commands as sw_vers making it possible to build 2 version kanata based on macos version
A proposed solution would be using feature flags
An example would be using driverkit by default (macos version > 10) and usable with (macos version <= 10) building with --no-default-features --features karabiner_kext for example
Use a packaging/build system that does sandboxing
(I know this happens with Nix, but I assume this could happen with other methods/occasions, for example if sw_vers is not installed/exposed)
Expected behavior
driverkit building correctly
Kanata version
any kanata version >= 1.6.0
Debug logs
No response
Operating system
macOS
Additional context
No response
The text was updated successfully, but these errors were encountered:
jtroo
added
macos
Issue pertains to macos; jtroo has no macOS devices and does not maintain the support for it.
PRs welcome
jtroo has no plans to work on this at present, but PRs are welcome
labels
Aug 25, 2024
Requirements
Describe the bug
karabiner-driverkit uses
sw_vers
command at runtime for macos which leads to not being reproducible and build can fail in sandboxed environments.I've already created an issue on karabiner-driverkit repo (relevant issue).
This is problematic for systems like nix. (see relevant comment, )
Proposed solution
Not relying in runtime commands as
sw_vers
making it possible to build 2 version kanata based on macos versionA proposed solution would be using feature flags
An example would be using
driverkit
by default (macos version > 10) and usable with (macos version <= 10) building with--no-default-features --features karabiner_kext
for exampleDraft example of how I "patched" feature flags:
Draft kanata diff
Draft karabiner_driverkit diff
If you have any ideas do not mind sharing them
Relevant kanata config
No response
To Reproduce
Use a packaging/build system that does sandboxing
(I know this happens with Nix, but I assume this could happen with other methods/occasions, for example if
sw_vers
is not installed/exposed)Expected behavior
driverkit building correctly
Kanata version
any kanata version >= 1.6.0
Debug logs
No response
Operating system
macOS
Additional context
No response
The text was updated successfully, but these errors were encountered: