-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Improvements #15
Comments
As a note id really like to separate symmetry and contraction chains from the underlying tensor class. Derived classes can be as complicated as needed, but there should be a base class that is as bare bones as possible. |
That is already the design of the base class. Rob and I wanted the base class to be as minimal as possible. The contraction chains are handled by expression templates. Symmetry will likely follow the BlockedTensor class style. |
Hey @jturney, I am working at PNNL for the next few months. I will be planning on implementing DSRG with global arrays. I would be more than willing to test GlobalArrays for Ambit. Can you push those changes to Ambit? Or send me the code? |
@kannon92 Sure thing! I'll locate it and send it your way. |
Improvements
The following are improvements to Ambit that were brought up during the Tensor discussion at Emory with Psi4 developers:
Tests to conduct
The text was updated successfully, but these errors were encountered: