Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvements #15

Open
8 tasks
jturney opened this issue Jun 7, 2016 · 4 comments
Open
8 tasks

Code Improvements #15

jturney opened this issue Jun 7, 2016 · 4 comments

Comments

@jturney
Copy link
Owner

jturney commented Jun 7, 2016

Improvements

The following are improvements to Ambit that were brought up during the Tensor discussion at Emory with Psi4 developers:

  • Batching blocks/slices to/from disk
  • Memory manager
  • Improved algorithm for contraction chain
  • Permutational symmetry
  • Point group symmetry
  • Finish DiskTensor and ensure compatibility with CoreTensor.

Tests to conduct

  • With current distributed infrastructure, how does CTF perform. We fully acknowledge that we do not utilize CTF fully.
  • I have a GlobalArrays backend for Ambit that needs to be tested and benchmarked.
@dgasmith
Copy link
Collaborator

dgasmith commented Jun 7, 2016

As a note id really like to separate symmetry and contraction chains from the underlying tensor class. Derived classes can be as complicated as needed, but there should be a base class that is as bare bones as possible.

@jturney
Copy link
Owner Author

jturney commented Jun 7, 2016

That is already the design of the base class. Rob and I wanted the base class to be as minimal as possible. The contraction chains are handled by expression templates. Symmetry will likely follow the BlockedTensor class style.

@kannon92
Copy link
Contributor

kannon92 commented Jun 8, 2016

Hey @jturney, I am working at PNNL for the next few months. I will be planning on implementing DSRG with global arrays. I would be more than willing to test GlobalArrays for Ambit. Can you push those changes to Ambit? Or send me the code?

@jturney
Copy link
Owner Author

jturney commented Jun 8, 2016

@kannon92 Sure thing! I'll locate it and send it your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants