From 80da756066d78bf02059de53d04bd46dbb746aaa Mon Sep 17 00:00:00 2001 From: Fede Raimondo Date: Thu, 30 Nov 2023 10:24:01 +0100 Subject: [PATCH] [MAINT] Skip deslib until it is compatible with new numpy (#241) * Fix codespell * Skip some deslib tests --- README.md | 2 +- docs/index.rst | 2 +- julearn/models/tests/test_dynamic.py | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5e5fc3ca7..8ebba941f 100644 --- a/README.md +++ b/README.md @@ -49,4 +49,4 @@ If you use julearn in a scientific publication, please use the following referen > Hamdan, Sami, Shammi More, Leonard Sasse, Vera Komeyer, Kaustubh R. Patil, and Federico Raimondo. ‘Julearn: An Easy-to-Use Library for Leakage-Free Evaluation and Inspection of ML Models’. arXiv, 19 October 2023. https://doi.org/10.48550/arXiv.2310.12568. -Since julearn is also heavily reliant on scikit-learn, plase also cite them: https://scikit-learn.org/stable/about.html#citing-scikit-learn +Since julearn is also heavily reliant on scikit-learn, please also cite them: https://scikit-learn.org/stable/about.html#citing-scikit-learn diff --git a/docs/index.rst b/docs/index.rst index 70e6bdbc2..9b4f9c587 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -95,5 +95,5 @@ reference ML Models’. arXiv, 19 October 2023. https://doi.org/10.48550/arXiv.2310.12568. -Since julearn is also heavily reliant on scikit-learn, plase also cite +Since julearn is also heavily reliant on scikit-learn, please also cite them: https://scikit-learn.org/stable/about.html#citing-scikit-learn diff --git a/julearn/models/tests/test_dynamic.py b/julearn/models/tests/test_dynamic.py index 9860a277e..49b171d35 100644 --- a/julearn/models/tests/test_dynamic.py +++ b/julearn/models/tests/test_dynamic.py @@ -48,7 +48,6 @@ # Ignore deprecation warnings from deslib pytestmark = pytest.mark.filterwarnings("ignore::DeprecationWarning") - @fixture( params=[ "METADES", @@ -84,6 +83,7 @@ def all_deslib_algorithms(request: FixtureRequest) -> str: "algo_name", [lazy_fixture("all_deslib_algorithms")], ) +@pytest.mark.skip("Deslib is not compatible with new python. Waiting for PR.") def test_algorithms( df_iris: pd.DataFrame, algo_name: str, @@ -175,6 +175,7 @@ def test_wrong_algo(df_iris: pd.DataFrame) -> None: ShuffleSplit(n_splits=1), ], ) +@pytest.mark.skip("Deslib is not compatible with new python. Waiting for PR.") def test_ds_split_parameter(ds_split: Any, df_iris: pd.DataFrame) -> None: """Test ds_split parameter. @@ -200,6 +201,7 @@ def test_ds_split_parameter(ds_split: Any, df_iris: pd.DataFrame) -> None: @pytest.mark.parametrize("ds_split", [4, ShuffleSplit(n_splits=2)]) +@pytest.mark.skip("Deslib is not compatible with new python. Waiting for PR.") def test_ds_split_error(ds_split: Any, df_iris: pd.DataFrame) -> None: """Test ds_split errors.