Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Train/Validation functions #113

Open
samihamdan opened this issue Jan 14, 2021 · 2 comments
Open

[ENH] Train/Validation functions #113

samihamdan opened this issue Jan 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request Priority: High High Priority Issue

Comments

@samihamdan
Copy link
Collaborator

In some situations it is needed to only perform a normal training or simple (not nested) cv on a dataset. In others more frequent ones it will be important to be able to validate a model on new test data.
These functions should have the similar interface like run_crossvalidation to make the use of julearn intuitive and consistent.

@samihamdan samihamdan added the enhancement New feature or request label Jan 14, 2021
@fraimondo
Copy link
Contributor

Can we make it to 0.3.0 with this feature?

@fraimondo fraimondo added this to the v0.3.0 milestone Jul 21, 2022
@fraimondo fraimondo added the Priority: High High Priority Issue label Jul 21, 2022
@fraimondo fraimondo removed this from the v0.3.0 milestone Apr 6, 2023
@fraimondo
Copy link
Contributor

Implementation:

for the fit function, we need to encapsulate the firsts lines of code of run_cross_validation up to the check_cv function. Then we just need to call the pipeline with the fit method instead of cross_validate.

On the other hand, the predict function (which I consider to be the most needed function), needs to have as input the same data as run_cross_validation:

  • X
  • data

@fraimondo fraimondo self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: High High Priority Issue
Projects
None yet
Development

No branches or pull requests

2 participants