ListSet: addAll() and removeAll() unexpected behavior

[scottfones]

In using the ListSet#addAll(Collection<? extends T> c) we've run into unexpected behavior where only the first element of the collection c is added. We've encountered similar behavior in the ListSet#removeAll(Collection<?> c) method, except it seems to hang. We think both are due to a short circuit in the logical OR the methods employ.

Test class to reproduce:

class ListSetTest {

    private ListSet<Object> listSet;

    private Object objA;
    private Object objB;
    private Object objC;

    private Set<Object> testSet;

    @BeforeEach
    void init() {
        listSet = new ListSet<>();

        objA = new Object();
        objB = new Object();
        objC = new Object();

        testSet = new HashSet<>(Arrays.asList(objA, objB, objC));
    }

    @Test
    @Disabled("Seems to have a conditional short circuit")
    void testAddAll() {
        listSet.addAll(testSet); // only adds first
        assertEquals(3, listSet.size()); // 1
    }

    @Test
    @Disabled("Loops: Seems to have a conditional short circuit")
    void testRemoveAll() {
        listSet.add(objA);
        listSet.add(objB);
        listSet.add(objC);
        listSet.removeAll(testSet); // hangs
        assertEquals(0, listSet.size());
    }
}