Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Modal workaround #535

Open
matheus-rosa-jsm opened this issue Aug 13, 2024 · 1 comment
Open

[Fix] Modal workaround #535

matheus-rosa-jsm opened this issue Aug 13, 2024 · 1 comment

Comments

@matheus-rosa-jsm
Copy link
Contributor

The problem

In the version 7.0 of ionic ion-modal has an undesired behavion on backdrop. It block body scrolling.
Inonic issue: ionic-team/ionic-framework#23942
This issue was resolved in the new ionic maijor version, 8.0

What is needed

To avoid this behavior was created an workaround and it will be no longer needed after the ionic upgrade. So is necessary remove it.

PR with the workaround: #534

It's necessary remove all manual interaction with backdrop-no-scroll class:
document.body.classList.remove(BACKDROP_NO_SCROLL)

@tassioFront
Copy link
Contributor

We needed to improve the workaround as more issues were happening. The last adjustments are found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants