Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Servers tested with file editor" or "Servers tested with text editor" for Language servers #1095

Open
hongy19 opened this issue Jul 30, 2024 · 3 comments

Comments

@hongy19
Copy link

hongy19 commented Jul 30, 2024

What I am trying to do...

in current Language servers doc, it is mentioned

Servers tested with file editor

I think it should be ""Servers tested with text editor" since there is no "file enditor" in jupyter?

How I would like to learn how to do it...

How the project might keep the docs accurate...

@krassowski
Copy link
Member

The text editor on the code level is called file editor, see https://github.com/jupyterlab/jupyterlab/tree/main/packages/fileeditor

@hongy19
Copy link
Author

hongy19 commented Jul 30, 2024

The text editor on the code level is called file editor, see https://github.com/jupyterlab/jupyterlab/tree/main/packages/fileeditor

Thanks and it is first time I know "text editor" called "file editor" in code level. But I still suggest to call it "text editor" on documentation level since most of user only know "text editor' instead of "file editor".

@krassowski
Copy link
Member

Feel welcome to submit a PR!

hongy19 added a commit to hongy19/jupyterlab-lsp that referenced this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants