Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Point Cloud #103

Open
akaszynski opened this issue Mar 29, 2021 · 7 comments
Open

Support Point Cloud #103

akaszynski opened this issue Mar 29, 2021 · 7 comments

Comments

@akaszynski
Copy link
Contributor

Looking at pythreejs, it seems like it should be possible to add a point cloud. Any hints for getting this added? I'm fine with submitting a PR.

@akaszynski
Copy link
Contributor Author

My bad, it's in ipygany, just not documented:
https://github.com/QuantStack/ipygany/blob/9181b7d5408ee0304f50ae3fd22beab45076224a/ipygany/ipygany.py#L426-L433

Would be nice to have docs and a from_pyvista method. Mind if I leave this open to remind myself?

@akaszynski
Copy link
Contributor Author

Almost there. Is there any way to change the size of the points?

pc

@martinRenou
Copy link
Collaborator

Thanks for opening an issue!

Almost there. Is there any way to change the size of the points?

Unfortunately not yet. There are some limitations in the ThreeJS Materials I am using in ipygany (see mrdoob/three.js#18153). I will try to allocate some time this week for this and other ipygany stuffs and release it :)

@akaszynski
Copy link
Contributor Author

I'm working on supporting ipygany in pyvista/pyvista#1239, and adding features like point sizes and wireframes would be really helpful. I realize that much needs to be added under the hood to support this, but I'd really like to be able to mirror many of the features available in vtk.js to ipygany since threejs is a bit more performant. A few features would be super valuable like:

  • wireframe representation
  • opacity
  • lighting control
  • Unbuffered arrays (enables smooth shading and seems more efficient)

Please let me know if I can help out.

@deeplook
Copy link

Any update on this?

@akaszynski
Copy link
Contributor Author

Note that pyvista now supports using pythreejs: https://docs.pyvista.org/user-guide/jupyter/pythreejs.html

You can use a ton of features that are unavailable in ipygany.

@deeplook
Copy link

Correct, I'm using it already. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants