Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Mesh #97

Open
akaszynski opened this issue Mar 13, 2021 · 1 comment
Open

Hide Mesh #97

akaszynski opened this issue Mar 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@akaszynski
Copy link
Contributor

Great work with this module!

Is there any way of toggling the visibility of a mesh? I'm trying to incorporate this with ipytree, but there's no callback or trait that lets me toggle the global visibility of a mesh. Is this a low hanging PR?

@martinRenou
Copy link
Collaborator

Thanks for the kind words!

I'm trying to incorporate this with ipytree

I originally created ipytree with this exact purpose in mind!

but there's no callback or trait that lets me toggle the global visibility of a mesh. Is this a low hanging PR?

It's unfortunately not possible as of today. And it requires changes in https://github.com/QuantStack/GanyJS. It would need adding a setter for visible just like for the defaultColor in here: https://github.com/QuantStack/GanyJS/blob/master/src/Block.ts#L192 (this requires adding a setter for visible in this class as well that does this.mesh.visible = visibility).

Then we need to update ipygany to expose the visible trait to Python.

@martinRenou martinRenou added the enhancement New feature or request label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants