Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable the news / Notebook 7 migration banner #242

Closed
andrii-i opened this issue Apr 14, 2023 · 9 comments · Fixed by #243
Closed

Add an option to disable the news / Notebook 7 migration banner #242

andrii-i opened this issue Apr 14, 2023 · 9 comments · Fixed by #243
Assignees

Comments

@andrii-i
Copy link

andrii-i commented Apr 14, 2023

#215 introduced news / Notebook 7 migration banner. This a good informational feature for self-managed users but it presents problems in settings where user's environment is managed and updating something can lead to environment breaking or not working properly.

In Notebook 7 you can disable the banner display using show_banner trait (#6808). Making the same option available in nbclassic would solve the problem.

@matthew-brett
Copy link

Agree - this is frustrating and confusing for our users of a JupyterHub cluster.

@echarles
Copy link
Member

I can work on this begin next week.

@echarles
Copy link
Member

See jupyter/notebook_shim#29 and #243

This feature can take some time as depends on a new notebook_shim release.

@santiagobasulto
Copy link

I added this bit to custom.css as a quick fix for now:

#newsId {
    display: none
}

@santiagobasulto
Copy link

@RRosio thanks! which version of nbclassic is this/will this fix tied to?

@echarles
Copy link
Member

@santiagobasulto this will be available in the next release. I will try to cut one this week.

@echarles
Copy link
Member

@santiagobasulto nbclassic 0.5.6 is released and allows you to disable the banner display with --NotebookApp.show_banner=False.

@santiagobasulto
Copy link

Thanks @echarles!!!

matthew-brett added a commit to lisds/lisds-images that referenced this issue Apr 27, 2023
@matthew-brett
Copy link

My attempt to apply this config to a JupyterHub setup : lisds/lisds-images@4ced070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants