Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipywidgets version in tests #192

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix ipywidgets version in tests #192

merged 1 commit into from
Jan 10, 2022

Conversation

martinRenou
Copy link
Member

Fix #191

@martinRenou
Copy link
Member Author

This is temporary, the https://github.com/jupyter/nbclient/blob/master/nbclient/tests/files/JupyterWidgets.ipynb Notebook outputs should probably be regenerated when ipywidgets 8 is out

@davidbrochart davidbrochart merged commit e82c5d8 into jupyter:master Jan 10, 2022
@davidbrochart
Copy link
Member

Thanks!

@martinRenou martinRenou deleted the fix_ipywidgets_pinning branch January 10, 2022 09:01
@bnavigator bnavigator mentioned this pull request Jan 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility of tests with ipywidgets 8 beta 1
2 participants
@martinRenou @davidbrochart