From a0503629ba4a0203f10eac5d4b723025269f5e49 Mon Sep 17 00:00:00 2001 From: Thomas Kluyver Date: Sat, 14 Jul 2018 10:52:51 +0200 Subject: [PATCH] Disable the host check for 5.6 because of gh-3754 --- docs/source/changelog.rst | 1 + notebook/notebookapp.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 2b9e81a58e..0e9ec4c0f3 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -34,6 +34,7 @@ New features: checking the ``Host`` header from the browser (:ghpull:`3714`). This check can be disabled if necessary by setting ``NotebookApp.allow_remote_access``. + (Disabled by default while we work out some Mac issues in :ghissue:`3754`). - Add kernel_info_timeout traitlet to enable restarting slow kernels (:ghpull:`3665`) - Add ``custom_display_host`` config option to override displayed URL (:ghpull:`3668`) - Add /metrics endpoint for Prometheus Metrics (:ghpull:`3490`) diff --git a/notebook/notebookapp.py b/notebook/notebookapp.py index 7500fcc262..20edc14d29 100755 --- a/notebook/notebookapp.py +++ b/notebook/notebookapp.py @@ -852,6 +852,10 @@ def _token_changed(self, change): @default('allow_remote_access') def _default_allow_remote(self): """Disallow remote access if we're listening only on loopback addresses""" + # Disable the check temporarily because of Mac issues: + # https://github.com/jupyter/notebook/issues/3754 + return True + try: addr = ipaddress.ip_address(self.ip) except ValueError: