Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD: Proposal to Add Keybindings for Additional JupyterCAD Commands #396

Closed
arjxn-py opened this issue Aug 15, 2024 · 4 comments · Fixed by #451
Closed

RFD: Proposal to Add Keybindings for Additional JupyterCAD Commands #396

arjxn-py opened this issue Aug 15, 2024 · 4 comments · Fixed by #451
Milestone

Comments

@arjxn-py
Copy link
Member

Currently, JupyterCAD supports keybindings for a few essential commands such as undo, redo, and removeObject. However, there are several other commands in JupyterCAD that would benefit from having dedicated keybindings to enhance UX.

Proposed Keybindings(Draft):

  • New Sketch: Ctrl + Shift + N
  • New Box: Ctrl + Shift + B
  • New Cylinder: Ctrl + Shift + C
  • New Sphere: Ctrl + Shift + S
  • New Cone: Ctrl + Shift + E
  • New Torus: Ctrl + Shift + T
  • Cut: Ctrl + X
  • Extrusion: Ctrl + Shift + E
  • Union: Ctrl + U
  • Intersection: Ctrl + I
  • Chamfer: Ctrl + Shift + F
  • Fillet: Ctrl + F
  • Update Axes: Ctrl + Shift + A
  • Update Exploded View: Ctrl + Shift + V
  • Update Camera Settings: Ctrl + Shift + K
  • Update Clip View: Ctrl + Shift + L
  • Export Jcad: Ctrl + Shift + X
@arjxn-py
Copy link
Member Author

  • New Box: Ctrl + Shift + B
  • New Cylinder: Ctrl + Shift + C
  • New Sphere: Ctrl + Shift + S
  • New Cone: Ctrl + Shift + E
  • New Torus: Ctrl + Shift + T

I think these may also be fine to skip

@trungleduc
Copy link
Member

Thanks for the suggestion. I think we should keep it consistent by prefixing all shortcuts with Ctrl + Shift and should avoid collision with JupyterLab shortcuts

kb

@trungleduc
Copy link
Member

  • New Box: Ctrl + Shift + B
  • New Cylinder: Ctrl + Shift + C
  • New Sphere: Ctrl + Shift + S
  • New Cone: Ctrl + Shift + E
  • New Torus: Ctrl + Shift + T

I think these may also be fine to skip

I have no issues keeping these shortcuts

@arjxn-py
Copy link
Member Author

I think we should keep it consistent by prefixing all shortcuts with Ctrl + Shift and should avoid collision with JupyterLab shortcuts

That sounds good, thanks. Would you want pre-existing keyboard shortcuts (i.e. Ctrl+Z, Ctrl+Y & Delete) to also have prefix Ctrl + Shift?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants