Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX of the clip-plane and wireframe buttons #406

Closed
martinRenou opened this issue Sep 10, 2024 · 2 comments · Fixed by #441
Closed

Improve the UX of the clip-plane and wireframe buttons #406

martinRenou opened this issue Sep 10, 2024 · 2 comments · Fixed by #441
Assignees
Milestone

Comments

@martinRenou
Copy link
Member

martinRenou commented Sep 10, 2024

Problems

Today, the clip-plane toolbar button shows a dialog to select two options:

  • selected
  • show Clip Plane

In the other side, the wireframe button does not show a dialog and directly apply the wireframe effect. Though once toggled, there is no visual indication in the toolbar that the button has been toggled.

Also, refreshing the page or reopening the file does not keep the clip-plane or wireframe states. We could fix this by saving the states in the schema.

Suggestions

  • We could make the behavior more homogeneous by making the clip-plane toolbar button not showing a dialog and directly toggling the clip-plane effect (we would always show the clip-plane in the 3D scene by default).
  • We should show a visual indication in the toolbar that toggle buttons are toggled
  • We should save the states of the clip-plane and wireframe effect in the schema
@martinRenou
Copy link
Member Author

cc. @arjxn-py

@arjxn-py
Copy link
Member

Thanks @martinRenou, it is well defined. I'll be happy to look into it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants