Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support automatic Let's Encrypt #108

Closed
wants to merge 21 commits into from
Closed

Support automatic Let's Encrypt #108

wants to merge 21 commits into from

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented May 18, 2020 •
edited
Loading

This PR adds:

  • Support configuring acme when proxy is started by the Hub
    • http challenge only
  • Auto https test
  • Update docs

Closes #105

consideRatio
consideRatio reviewed May 18, 2020
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 18, 2020
View reviewed changes
tests/proxytest.py Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 19, 2020
View reviewed changes
docs/source/https.md Outdated Show resolved Hide resolved
minrk
minrk reviewed May 19, 2020
View reviewed changes
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super exciting!

jupyterhub_traefik_proxy/proxy.py Outdated Show resolved Hide resolved
jupyterhub_traefik_proxy/proxy.py Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 19, 2020
View reviewed changes
docs/source/https.md Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 21, 2020
View reviewed changes
docs/source/https.md Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 21, 2020
View reviewed changes
docs/source/https.md Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed May 21, 2020
View reviewed changes
docs/source/https.md Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed Jun 3, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
consideRatio
consideRatio reviewed Jun 3, 2020
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
GeorgianaElena and others added 2 commits June 3, 2020 18:04
consideRatio
consideRatio approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I've not tested this myself or so, but it seems like a safe merge that locks in configuration that i think makes sense!

@GeorgianaElena
Copy link
Member Author

@minrk, do you think there is anything else I should change/improve before merging this?
(sorry for the ping)

@alexleach alexleach mentioned this pull request Jul 5, 2021
Closed
@minrk minrk mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk left review comments

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support automatic Let's Encrypt certificate aquisition
3 participants
@GeorgianaElena @minrk @consideRatio