Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure provider from traitlets/command line #1055

Open
krassowski opened this issue Oct 25, 2024 · 3 comments
Open

Allow to configure provider from traitlets/command line #1055

krassowski opened this issue Oct 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@krassowski
Copy link
Member

Problem

Currently individual models may receive additional arguments using AIExtension.model_parameters. This only works if one wants to customize one specific model, not all models of a given provider (e.g. setting a proxy URL for all of them).

Proposed Solution

Add AIExtension.provider_parameters with precedence lower than AIExtension.model_parameters.

Additional context

None

@krassowski krassowski added the enhancement New feature or request label Oct 25, 2024
@dlqqq
Copy link
Member

dlqqq commented Oct 29, 2024

@krassowski I feel like this issue would be solved if we simply allowed glob expressions matching model IDs to be specified in the allowlist, denylist, and as keys in model_parameters. That way, we don't need 2 traitlets for every configuration field (one model-scoped and one provider-scoped), which I think could be confusing for operators.

I think it's important to recognize that operator personas (e.g. sysadmins) are often less experienced with Jupyter AI than user personas, so ideally, we shouldn't require them to understand the distinction between providers & models when configuring their deployments.

What do you think about implementing model ID globs for traitlets in v3? I can open an issue for that if it seems like a good feature to have in v3.

@krassowski
Copy link
Member Author

Yes, that would work and sounds like indeed less work to maintain - thank you! A regex or a glob would be sufficient.

@krassowski
Copy link
Member Author

Feel free to rename this issue if you prefer that over opening a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants