Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated CVC and expiry behaviour #840

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: updated CVC and expiry behaviour #840

wants to merge 5 commits into from

Conversation

aritro2002
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

CVC number is not being trimmed after changing the card brand from American Express to Visa.

How did you test it?

Screen.Recording.2024-12-17.at.11.23.25.AM.mov

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@aritro2002 aritro2002 added the Ready for Review PR with label Ready for Review should only be reviewed. label Dec 17, 2024
@aritro2002 aritro2002 self-assigned this Dec 17, 2024
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@aritro2002 aritro2002 linked an issue Dec 17, 2024 that may be closed by this pull request
trim card CVC number if it exceeds max length of new card brand #841
Open
@aritro2002 aritro2002 changed the title fix: trim card CVC number if it exceeds max length of new card brand fix: updated CVV behavior Dec 18, 2024
@aritro2002
Copy link
Contributor Author

aritro2002 commented Dec 18, 2024 •
edited
Loading

Screen.Recording.2024-12-18.at.4.30.13.PM.mov

The modified behaviour of CVV input:

  1. The cvv will be cleared when the card number is empty
  2. The CVV will be cleared when the card brand changed

@aritro2002
Copy link
Contributor Author

Screen.Recording.2024-12-18.at.6.22.03.PM.mov

@aritro2002 aritro2002 changed the title fix: updated CVV behavior fix: updated CVC and expiry behaviour Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja left review comments

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@aritro2002 aritro2002

Labels
Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trim card CVC number if it exceeds max length of new card brand
2 participants
@aritro2002 @PritishBudhiraja