Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --quiet --quiet wherever possible to Nix #300

Open
srid opened this issue Oct 7, 2024 · 4 comments
Open

Use --quiet --quiet wherever possible to Nix #300

srid opened this issue Oct 7, 2024 · 4 comments

Comments

@srid
Copy link
Member

srid commented Oct 7, 2024

Also, the second quiet level hides "Added input" output? That's interesting; I wonder if we can do that for other commands (not in this PR).

Yes, it does

Originally posted by @shivaraj-bh in #298 (comment)

image
@srid
Copy link
Member Author

srid commented Nov 8, 2024

Given #324 (comment) - it doesn't look to make sense to use --quiet --quiet for anything nix build related. I didn't realize it suppresses these kinds of logs too:

image

@shivaraj-bh
Copy link
Member

In that case it should probably make sense to just use it for subcommands show and health. It is not a necessity for health at the moment, but when we use flake-schemas to detect the om.health config, it will be.

So, should we close #324 now and revisit when om health gets flake-schemas treatment?

@shivaraj-bh
Copy link
Member

Or maybe even other sub-commands where nix eval will be used?

@srid
Copy link
Member Author

srid commented Nov 8, 2024

In that case it should probably make sense to just use it for subcommands show and health. It is not a necessity for health at the moment, but when we use flake-schemas to detect the om.health config, it will be.

So, should we close #324 now and revisit when om health gets flake-schemas treatment?

Yes, let's do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants