Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to the translation icon #700

Open
camillaryd opened this issue Jul 13, 2016 · 6 comments
Open

Add label to the translation icon #700

camillaryd opened this issue Jul 13, 2016 · 6 comments

Comments

@camillaryd
Copy link
Collaborator

Description

Someone picked this icon to signify the automatic translation is on or off. This needs to be explained in words otherwise we don't understad or see it. See the sketch below.

desktop

@buren
Copy link
Member

buren commented Jul 13, 2016

I couldn't agree more, even I that now what it means have trouble seeing the difference in colour.

@buren
Copy link
Member

buren commented Jul 13, 2016

@lenaar perhaps something that you'd like to add? :)

@pstenstrm
Copy link
Contributor

We have the issue #576. Should we still do that in combination or close it for the benefit of this issue?

@lenaar
Copy link
Contributor

lenaar commented Jul 13, 2016

I can do both of them I guess, they are bit different issues but for the same element, one is just add text alternative, another one is add color

@pstenstrm
Copy link
Contributor

pstenstrm commented Jul 13, 2016

That's true, but I think both issues are ment to fix related problems. We wanted to change the color to pink because we couldn't really see if the icon is active or not.

I don't think we "need" to add the color after we have added the text label, since the label should solve both issues.

@camillaryd
Copy link
Collaborator Author

I say start with the text label and make the link blue if the background is white to make it more visible.

@buren buren added the ready label Sep 12, 2016
@buren buren unassigned belev Sep 16, 2016
@buren buren modified the milestone: v1.1 Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants