Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for custom classes [Feature Request] #33

Open
colin-marshall opened this issue Sep 27, 2017 · 4 comments
Open

Add options for custom classes [Feature Request] #33

colin-marshall opened this issue Sep 27, 2017 · 4 comments

Comments

@colin-marshall
Copy link

Right now we are stuck with having class="trail-items" and class="trail-item for <ul> and <li> items respectively. It would be great if we had the option to use custom classes for the <ul> and <li> items.

I can put in a pull request if you are interested.

@justintadlock
Copy link
Owner

justintadlock commented Sep 27, 2017

Perhaps list_attr and item_attr (for controlling all element attributes) might be even better. I can pull this from already existing code I have in other projects.

@colin-marshall
Copy link
Author

colin-marshall commented Sep 27, 2017 via email

@Log1x
Copy link

Log1x commented Sep 30, 2017

I actually did a fork adding classes but thought this project was abandoned..

https://github.com/Log1x/breadcrumb-trail

Want me to redo my changes for dev-master and submit a proper PR? I also added Composer support and bumped the after_theme_setup for current_theme_supports up in priority as it wasn't firing in Sage 9's default setup.php

@MrAndreius
Copy link

Please add to
// Open the unordered list. <%s class="trail-items" itemscope itemtype="http://schema.org/BreadcrumbList">

the ability to specify your own class list_class
something like that
<ul class="trail-items breadcrumbs" itemscope itemtype="http://schema.org/BreadcrumbList">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants