-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple crumb anchors in a single item #35
Comments
I don't think there'd be an issue changing the regex. However, I do want to note that I have plans changing how a lot of this works in a future version to the point where I wouldn't need the regex at all. Right now, trail items are defined like:
That's pretty inflexible and means for a lot of duplicated code just making the markup. Eventually, I'd want something more along the lines of:
Then, I'd have a function that handled the markup. I mention this because I'd want to think about that future compatibility before making a change now that would break something later. |
Oh yeah, that plan sounds fine to me. My subclass can easily adjust. PS For time being I'm deploying a patch on top of |
Use case: e-learning environment, where courses can belong to multiple certificate programs.
Breadcrumb structure goal (pardon the ASCII limitations,
vertical-align: middle
would be nicer):HTML (styled into multi-line later):
Solution: seems simple on surface, https://github.com/justintadlock/breadcrumb-trail/blob/1.1.0/inc/breadcrumbs.php#L200 should become greedy instead of lazy. Can we lose the lazy
?
from matching between<a></a>
?Side effects: none that I can see on 1.0.0, but I have yet to test 1.1.0.
Alternatively, it would help if the
preg_match()
call is put through a filter, so I could run my own regex on it.The text was updated successfully, but these errors were encountered: