Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter blocks drop-database #32

Open
zesoup opened this issue Jul 5, 2019 · 0 comments
Open

Exporter blocks drop-database #32

zesoup opened this issue Jul 5, 2019 · 0 comments

Comments

@zesoup
Copy link

zesoup commented Jul 5, 2019

Hi,

as the exporter keeps its connection open between scrapes it becomes harder to drop an unused database.

I feel like disconnecting once a scrape is finished serves multiple purposes. It becomes quite obvious for the monitoring once no more connections can be established and as these connections are not permanent it becomes more feasible to use this exporter in a many-database and autodiscovery szenarios. Last but not least there is a DROP DATABASE enhancement as one is currently required to manually remove monitoring connections.

If required i'll provide the patch - would this approach be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant