Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method event emitted after frame event #237

Open
urisimchoni opened this issue Mar 7, 2018 · 1 comment
Open

Method event emitted after frame event #237

urisimchoni opened this issue Mar 7, 2018 · 1 comment

Comments

@urisimchoni
Copy link
Contributor

In:

inspectMethod(methodId, frame);

Wouldn't it make sense to inspect the method first, so as to emit the method event before the frame event, thus making it easy on log consumers? That would ensure that when a log consumer gets an event with a method ID, it has already seen the mapping to method name, and it can emit the method name (for example, the ConsoleLogDumpApplication fails to emit the method name when it first encounters it).

Such a change at the very least would break tests, so I'm not issuing a PR yet, just asking if it makes sense and whether it breaks anything beside tests which depend on the exact current implementation.

@nitsanw
Copy link
Member

nitsanw commented Apr 3, 2018

It makes sense IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants