You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wouldn't it make sense to inspect the method first, so as to emit the method event before the frame event, thus making it easy on log consumers? That would ensure that when a log consumer gets an event with a method ID, it has already seen the mapping to method name, and it can emit the method name (for example, the ConsoleLogDumpApplication fails to emit the method name when it first encounters it).
Such a change at the very least would break tests, so I'm not issuing a PR yet, just asking if it makes sense and whether it breaks anything beside tests which depend on the exact current implementation.
The text was updated successfully, but these errors were encountered:
In:
honest-profiler/src/main/cpp/log_writer.cpp
Line 120 in 89223b8
Wouldn't it make sense to inspect the method first, so as to emit the method event before the frame event, thus making it easy on log consumers? That would ensure that when a log consumer gets an event with a method ID, it has already seen the mapping to method name, and it can emit the method name (for example, the ConsoleLogDumpApplication fails to emit the method name when it first encounters it).
Such a change at the very least would break tests, so I'm not issuing a PR yet, just asking if it makes sense and whether it breaks anything beside tests which depend on the exact current implementation.
The text was updated successfully, but these errors were encountered: