-
Notifications
You must be signed in to change notification settings - Fork 283
Clean up our main script #65
Comments
Maybe rewrite the whole thing in Go? ;) |
Do you think a script based on the Bash3 boilerplate and trying to show little to no errors from ShellCheck would be a good idea ? I'm worried the MIT licence from the Bash3 boilerplate can be an issue... |
I'm not a big fan of bringing in a whole external dependency for our simple'n'stupid bash script tbh :/ But the shellcheck idea is great, I think that we ran it on the codebase at some point. |
I don't see it as importing a whole external dependency, but rather using some ideas (see the Scoping, Coding style and Safety and Portability parts on b3bp website) or some parts of it. For instance, I started to :
|
Be my guest if you want to improve the script, I'll be happy to review your PR :) |
Currently, our main script's code looks quite ugly. It would be nice if someone with some shell-fu could take a look at it, and clean it up.
The text was updated successfully, but these errors were encountered: