Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't load simple model (with 8bit and 16bit inputs) #28

Open
ordicker opened this issue Jul 18, 2023 · 5 comments
Open

Can't load simple model (with 8bit and 16bit inputs) #28

ordicker opened this issue Jul 18, 2023 · 5 comments

Comments

@ordicker
Copy link

Hi nice package!

I'm trying to add new ops to ONNX.jl, and I use this package to test if the onnx file is valid (loadable and return the right results).
I'm using Onnx backend test suit and I think where is a bug on this package, but I'm not sure.

Here is a minimal working example:
That's a simple model for the "test_min_int16" model.zip. Basically, it's min(x,y) graph where x,y are INT16.

import ONNXRunTime as OX
OX.load_inference("model.onnx") #<test_dir>/data/node/test_min_int16/model.onnx

And I get this:

ERROR: Could not find an implementation for Min(13) node with name ''

I think that should work.

For "test_min_int32" is it working. (the whole test suit)

@jw3126
Copy link
Owner

jw3126 commented Jul 18, 2023

Do you know if your model loads using onnxruntime from C or python?

@ordicker
Copy link
Author

ordicker commented Jul 18, 2023

import onnx
onnx.load("<path>/model.onnx")

works

@jw3126
Copy link
Owner

jw3126 commented Jul 18, 2023

Ok, thanks, so it is likely a bug in this package! I don't have enough time to work on this. If you feel like doing this, here is one approach to pinpoint the bug:

  1. Load the model from C
  2. If that works use the low-level API of this package ONNXRunTime.CAPI to 1:1 translate the C code to julia, see the example in the README.

@ordicker
Copy link
Author

It is in onnxruntime :(

Issue

Now, I'm not sure how the python version works

@jw3126
Copy link
Owner

jw3126 commented Jul 23, 2023

thanks a lot for digging into this! I never looked into the python implementation, but I am also curious how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants