Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Lexer should not require a file id #435

Open
jyn514 opened this issue May 14, 2020 · 0 comments
Open

Lexer should not require a file id #435

jyn514 opened this issue May 14, 2020 · 0 comments
Labels
enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program
Milestone
Preprocessor for ...

Comments

@jyn514
Copy link
Owner

jyn514 commented May 14, 2020

The Lexer is meant for only single files, so there's no need for it to take a FileId in the constructor. Instead it should return locations meant for only a single file, which the preprocesssor can then add file metadata to.

Found while writing up rust-lang/rust-bindgen#1782.
@jyn514 jyn514 added enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program labels May 14, 2020
@jyn514 jyn514 added this to the Preprocessor for bindgen milestone May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program
Projects
None yet
Milestone
Preprocessor for bindgen
Development

No branches or pull requests
1 participant
@jyn514