Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot save cropped image (non-jpg image file) #29

Open
fongaboo opened this issue Sep 6, 2020 · 4 comments
Open

cannot save cropped image (non-jpg image file) #29

fongaboo opened this issue Sep 6, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fongaboo
Copy link

fongaboo commented Sep 6, 2020

Getting this everytime I attempt a crop:

IMG_20200906_090404_704

Android 7.1.2 LineageOS 14.1

@k3b
Copy link
Owner

k3b commented Sep 7, 2020

does this happen with every jpg file that you try to crop?
have you tried to save the croped file to a different folder?

@ShamrockLee
Copy link

ShamrockLee commented Nov 20, 2020

It also happens to me.
It doesn't happen to every JPEG files. When the issue happens, it is of no use to save to different folders.

@k3b
Copy link
Owner

k3b commented Nov 20, 2020

While the visible gui part of llcrop can handle jpg/gif/png
the processing part (i.e. the lossless cropping library) can only handle jpg files (but not pngs or gifs.)

The errormessage "cannot transcode" is an indecator for non-jpg.

TODO:

add lossy cropping of non jpg-files with a warning that quality may be lost

@k3b k3b changed the title No longer working Cannot crop non-jpg image Nov 20, 2020
@k3b k3b added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed waiting for feedback labels Nov 20, 2020
@k3b k3b changed the title Cannot crop non-jpg image cannot save cropped image (non-jpg image file) Nov 20, 2020
@Mafiadoener36
Copy link

Mafiadoener36 commented Oct 11, 2023

Coming from "Aves" gallery sharing a png screenshot to llcrop failes with the same error message if i then wanna save or redrirect further - even though i can visually edit first inside the gui.

First sharing to "imagepipe" - then as jpg to llcrop - "fixed" this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants