Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with big images #34

Open
xandro0777 opened this issue Jun 4, 2022 · 4 comments
Open

Doesn't work with big images #34

xandro0777 opened this issue Jun 4, 2022 · 4 comments
Labels
enhancement New feature or request feature request

Comments

@xandro0777
Copy link

Hi, my camera can save jpeg pictures as 9248x6944. when trying to crop such images the app displays only a white canvas with the grid and movable corners but not the image.

The canvas can be (blindly) cropped and everything behaves like normal but the resulting picture is just the canvas.

Looked at logs but cant see anything obvious.

It works very nicely fro smaller pictures.

Github doesn't even allow me to attach an example file saying it is too big...

@k3b
Copy link
Owner

k3b commented Jun 5, 2022

hello @xandro0777

(Question 1) did i understood you correctly that this is only a display problem that huge image is not displayed and selecting cropping area and cropping is working as expected ==> you get a cropped image.

if i am correct with the interpretation of your ticket i might be able to fix it.

(Question 2) Do you know any opensource android app that can display the huge images where i can look at the java-source code to see how the authors managed to display the image?

as far as i know android itselelf has an image display limit on 4096 x 4096: if widht or high exceeds 4096 it cannot be displayed the usual way.

(Question 3) Do you have a drawing program that can create jpg files bigger than 4096 x 4096?
can you draw me a simple huge hello-world image black&white image that has few megabytes i can use to test with?

if you have positive answers to question 1,2,3 i will try to fix my app.

(question 4) is this ticket related to #25 ?

@k3b k3b added enhancement New feature or request question Further information is requested feature request waiting for feedback labels Jun 5, 2022
@xandro0777
Copy link
Author

(Question 1) did i understood you correctly that this is only a display problem that huge image is not displayed and selecting cropping area and cropping is working as expected ==> you get a cropped image.

cropping works but the white/blank image is cropped resulting in a all-white image of the desired dimensions that can be saved. So it is not a display only problem.

(Question 2) Do you know any opensource android app that can display the huge images where i can look at the java-source code to see how the authors managed to display the image?

https://f-droid.org/en/packages/com.simplemobiletools.gallery.pro

https://f-droid.org/en/packages/us.koller.cameraroll

https://f-droid.org/en/packages/org.catrobat.paintroid

https://f-droid.org/en/packages/com.alienpants.leafpicrevived

(Question 3) Do you have a drawing program that can create jpg files bigger than 4096 x 4096? can you draw me a simple huge hello-world image black&white image that has few megabytes i can use to test with?

I have piped the image through image magick to reduce the file size and attached it to this comment. Still the same result so apparently it is the image dimensions, not file size.
small

(question 4) is this ticket related to #25 ?

doesn't look like that, saving works.

@xandro0777
Copy link
Author

Sendreduced also works and might be easier to grep https://f-droid.org/en/packages/mobi.omegacentauri.SendReduced

@k3b
Copy link
Owner

k3b commented Jun 7, 2022

ok thanks for the feedback. i saved you example big image for further investigaton.

since this is a hobby project and i am currently busy with other activities it may take some time to solve this issue. the other opensource example are valueable infos for me....

@k3b k3b removed question Further information is requested waiting for feedback labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

No branches or pull requests

2 participants