Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom path for runtimes autodetect #10761

Open
Ivan-Rosa opened this issue Aug 28, 2024 · 2 comments
Open

Custom path for runtimes autodetect #10761

Ivan-Rosa opened this issue Aug 28, 2024 · 2 comments

Comments

@Ivan-Rosa
Copy link

Is your feature request related to a problem? Please describe.
I'm using rke2 with Flatcar OS, using a custom path to install Nvidia toolkit.
Because of this custom path, runtimes autodetect is not finding nvidia runtime.

Describe the solution you'd like
It would be nice to be allowed to add some custom path in

runtimesPath = "/usr/local/nvidia/toolkit:/opt/kwasm/bin:/usr/sbin:/usr/local/sbin:/usr/bin:/usr/local/bin"

os.Setenv("PATH", runtimesPath)

@brandond
Copy link
Contributor

Where does Flatcar want to put things? Can you symlink them into one of the expected paths?

@vitorsavian
Copy link
Member

@brandond maybe could we do something like this to support more paths? since we still will get the paths that we want and the user can add his path to the search too

runtimesPath = "/usr/local/nvidia/toolkit:/opt/kwasm/bin"

originalPath := os.Getenv("PATH")
os.Setenv("PATH", runtimesPath + os.PathSeparator + originalPath)
extraRuntimes := findContainerRuntimes()
os.Setenv("PATH", originalPath)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

4 participants
@brandond @vitorsavian @Ivan-Rosa and others