Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload E2E logs on failure as GHA artifacts #11514

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Jan 3, 2025

Proposed Changes

  • Upload journald logs of each node as a GHA artifact on E2E test failure. An improvement over just dumping it into the output.
  • Improved logic for forks when running the go docker tests in determining the "parent" branch that a PR comes from.

Types of Changes

Verification

See this run, where WASM and Private registry E2E tests were purposely failed. Note the available log artifacts
https://github.com/dereknola/k3s/actions/runs/12602264364

Testing

Its all testing

Linked Issues

#11532

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner January 3, 2025 20:01
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.44%. Comparing base (e64e2fc) to head (7d9560b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11514      +/-   ##
==========================================
- Coverage   43.85%   39.44%   -4.41%     
==========================================
  Files         181      164      -17     
  Lines       18809    18330     -479     
==========================================
- Hits         8249     7231    -1018     
- Misses       9351     9895     +544     
+ Partials     1209     1204       -5     
Flag Coverage Δ
e2etests 35.81% <ø> (+0.01%) ⬆️
inttests 35.02% <ø> (+0.04%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola changed the title [WIP] Upload E2E logs on failure as GHA artifacts Upload E2E logs on failure as GHA artifacts Jan 6, 2025
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@dereknola dereknola merged commit 2f432a1 into k3s-io:master Jan 7, 2025
38 checks passed
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jan 13, 2025
* Upload E2E journald logs as artifacts in GHA

Signed-off-by: Derek Nola <[email protected]>

* Improve fork information for parent extraction

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola deleted the test_logs branch January 16, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants