From 04834bff45da53ea2c404631c4b9b2db1a1a4636 Mon Sep 17 00:00:00 2001 From: Kiernan Nicholls Date: Thu, 5 Nov 2020 23:10:20 -0500 Subject: [PATCH] Release 0.3.12 to CRAN --- CRAN-RELEASE | 2 ++ cran-comments.md | 24 ++++++++++++++++++------ 2 files changed, 20 insertions(+), 6 deletions(-) create mode 100644 CRAN-RELEASE diff --git a/CRAN-RELEASE b/CRAN-RELEASE new file mode 100644 index 00000000..ceacd7d0 --- /dev/null +++ b/CRAN-RELEASE @@ -0,0 +1,2 @@ +This package was submitted to CRAN on 2020-11-05. +Once it is accepted, delete this file and tag the release (commit b42b9b9). diff --git a/cran-comments.md b/cran-comments.md index 9a0fb983..31081ea7 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -8,18 +8,32 @@ * win-builder: windows-x86_64-devel * https://win-builder.r-project.org/ANV0wwGa2RnH/ * r-hub: windows-x86_64-devel, ubuntu-gcc-release, fedora-clang-devel - * https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-8880c48e9fb3456d9237301782b6253c - * https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-93d173f6f5e64628b4f0703a611f3664 - * https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-4c5998ea86dd4127824cdc5736210ecf + * https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-b850b4a77c694edbb30f071e6230e021 + * https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-c251fe8fcb3e4b3d950a44d28bd2f9d8 + * https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-ab2074eef0d940d099c778c177ab8d04 ## R CMD check results -0 errors | 0 warnings | 1 note +0 errors | 0 warnings | 0 notes * This is a new release. ## Resubmission +* _All_ calls to an external API use `tryCatch()` and repeat the request should +it fail initially. The timeout options are no longer changed between attempts, +only sleeping. + +* The `all_players()` examples and tests are skipped because they take too long. +The stat scraping is also more careful when handling edge cases and should be +able to run at any time. + +* The vignette uses a know, past data point and no longer changes depending on +when it was run; this should prevent calls to `team_roster()`, etc from +returning some data that might not work in the rest of the vignette. + +## Previous Submission + * The `ffl_api()` now uses `tryCatch()` and re-tries to call the API when it fails, waiting with `Sys.sleep()` between attempts and adjusting the timeout `options()`. This should help prevent timeout failures in @@ -31,8 +45,6 @@ fails, waiting with `Sys.sleep()` between attempts and adjusting the timeout Timeout was reached: [fantasy.espn.com] Resolving timed out after 10001 milliseconds ``` -## Previous Submission - * [ESPN](https://en.wikipedia.org/wiki/ESPN) is not really an acronym, it no longer stands for anything and doesn't need to be explained in the DESCRIPTION.