From c33774a4811911e8c94f24854a66c028137793c8 Mon Sep 17 00:00:00 2001
From: Andrea Panattoni <apanatto@redhat.com>
Date: Thu, 5 Dec 2024 18:00:08 +0100
Subject: [PATCH 1/2] Unit test for RdmaMode

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
---
 .../sriovnetworknodepolicy_controller_test.go | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/controllers/sriovnetworknodepolicy_controller_test.go b/controllers/sriovnetworknodepolicy_controller_test.go
index abdddbc91..d5534f55e 100644
--- a/controllers/sriovnetworknodepolicy_controller_test.go
+++ b/controllers/sriovnetworknodepolicy_controller_test.go
@@ -260,4 +260,64 @@ var _ = Describe("SriovnetworkNodePolicy controller", Ordered, func() {
 			}, time.Minute, time.Second).Should(Succeed())
 		})
 	})
+
+	Context("RdmaMode", func() {
+		BeforeEach(func() {
+			Expect(
+				k8sClient.DeleteAllOf(context.Background(), &sriovnetworkv1.SriovNetworkPoolConfig{}, k8sclient.InNamespace(vars.Namespace)),
+			).ToNot(HaveOccurred())
+		})
+
+		It("field is correctly written to the SriovNetworkNodeState", func() {
+			node := &corev1.Node{ObjectMeta: metav1.ObjectMeta{
+				Name: "node0",
+				Labels: map[string]string{
+					"node-role.kubernetes.io/worker": "",
+					"kubernetes.io/os":               "linux",
+					"test":                           "",
+				},
+			}}
+			Expect(k8sClient.Create(ctx, node)).To(Succeed())
+
+			nodeState := &sriovnetworkv1.SriovNetworkNodeState{}
+			Eventually(func(g Gomega) {
+				err := k8sClient.Get(context.TODO(), k8sclient.ObjectKey{Name: "node0", Namespace: testNamespace}, nodeState)
+				g.Expect(err).ToNot(HaveOccurred())
+			}, time.Minute, time.Second).Should(Succeed())
+
+			nodeState.Status.Interfaces = sriovnetworkv1.InterfaceExts{
+				sriovnetworkv1.InterfaceExt{
+					Vendor:     "8086",
+					Driver:     "i40e",
+					Mtu:        1500,
+					Name:       "ens803f0",
+					PciAddress: "0000:86:00.0",
+					NumVfs:     0,
+					TotalVfs:   64,
+				},
+			}
+			err := k8sClient.Status().Update(context.Background(), nodeState)
+			Expect(err).ToNot(HaveOccurred())
+
+			poolConfig := &sriovnetworkv1.SriovNetworkPoolConfig{}
+			poolConfig.SetNamespace(testNamespace)
+			poolConfig.SetName("test-workers")
+			poolConfig.Spec = sriovnetworkv1.SriovNetworkPoolConfigSpec{
+				NodeSelector: &metav1.LabelSelector{
+					MatchLabels: map[string]string{
+						"test": "",
+					},
+				},
+				RdmaMode: "exclusive",
+			}
+			Expect(k8sClient.Create(ctx, poolConfig)).To(Succeed())
+
+			Eventually(func(g Gomega) {
+				err := k8sClient.Get(context.Background(), k8sclient.ObjectKey{Name: node.Name, Namespace: testNamespace}, nodeState)
+				g.Expect(err).ToNot(HaveOccurred())
+				g.Expect(nodeState.Spec.System.RdmaMode).To(Equal("exclusive"))
+			}).WithPolling(time.Second).WithTimeout(time.Minute).Should(Succeed())
+
+		})
+	})
 })

From fdffa3d56fb29a5359d641ed729cfbd01e65847e Mon Sep 17 00:00:00 2001
From: Andrea Panattoni <apanatto@redhat.com>
Date: Thu, 5 Dec 2024 18:07:47 +0100
Subject: [PATCH 2/2] Avoid overwriting coverage files for different
 `CLUSTER_TYPE`s

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f5ca7edc8..e70b591ac 100644
--- a/Makefile
+++ b/Makefile
@@ -229,7 +229,7 @@ test-bindata-scripts: fakechroot
 	fakechroot ./test/scripts/kargs_test.sh
 
 test-%: generate manifests envtest
-	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir=/tmp -p path)" HOME="$(shell pwd)" go test ./$*/... -coverprofile cover-$*.out -coverpkg ./... -v
+	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir=/tmp -p path)" HOME="$(shell pwd)" go test ./$*/... -coverprofile cover-$*-$(CLUSTER_TYPE).out -coverpkg ./... -v
 
 GOCOVMERGE = $(BIN_DIR)/gocovmerge
 gocovmerge: ## Download gocovmerge locally if necessary.