Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Chore: Use dto builders in controller package #504

Merged
merged 4 commits into from
Aug 7, 2024
Merged

BE: Chore: Use dto builders in controller package #504

merged 4 commits into from
Aug 7, 2024

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Jul 26, 2024 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
A little cleanup in the controller package.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner July 26, 2024 21:00
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 26, 2024
Haarolean
Haarolean requested changes Jul 27, 2024
View reviewed changes
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the openapi DTOs, I'd prefer to have builders rather than bulky constructors. As the built-in ones are deprecated for some reason, can I suggest adjusting openapi configuration adding additionalModelTypeAnnotations with lombok builder annotations?

@wernerdv
BE: Cleanup in controller package
5f00885 
BE: Cleanup in controller package
@wernerdv
Copy link
Contributor Author

@Haarolean Fixed

@Haarolean Haarolean self-requested a review July 28, 2024 08:31
@Haarolean Haarolean self-assigned this Jul 28, 2024
@Haarolean Haarolean changed the title BE: Cleanup in controller package BE: Chore: Use dto builders in controller package Aug 5, 2024
@Haarolean Haarolean added scope/backend Related to backend changes type/refactor Refactoring task and removed status/triage/manual Manual triage in progress labels Aug 5, 2024
@Haarolean Haarolean added this to the 1.1 milestone Aug 5, 2024
@Haarolean Haarolean merged commit 2bb9d5c into kafbat:main Aug 7, 2024
10 of 13 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Haarolean Haarolean

Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wernerdv @Haarolean