Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous offset commit requests should go directly to group_coordinator #361

Open
k32 opened this issue Nov 26, 2019 · 0 comments
Open

Comments

@k32
Copy link

k32 commented Nov 26, 2019

Currently brod_group_consumer:commit/4 function uses brod_group_consumer gen server as a proxy. However, this process can be blocked by CbModule:handle_message callback, and commit requests will linger in its message queue until it processes kafka message sets. This leads to undesirable delay until async offsets are committed. Also commit requests can be lost on restart. Proposal: this call should go directly to brod_group_coordinator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant