Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks order in job result array #203

Closed
claustres opened this issue Jun 24, 2022 · 1 comment
Closed

Tasks order in job result array #203

claustres opened this issue Jun 24, 2022 · 1 comment

Comments

@claustres
Copy link
Member

In previous versions tasks in job result array were ordered similarly as input tasks but following #151 tasks in job result array are now ordered according to their run duration: if a task finishes before another one it will be put before it in the result array.

This can causes problem to some hooks like mergeJson, which rely on the task result order. We should probably introduce a new sortBy hook when a specific order needs to be enforced or reorder the result array the same way input tasks are.

@claustres
Copy link
Member Author

Fixed by adding a sortBy option in the mergeJson hook as it's probably better to make each hook requiring a specific order to setup it.

@claustres claustres added this to the v2.0.0 milestone Jul 7, 2022
@claustres claustres moved this to Done in Krawler Roadmap Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant