-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the v prefix from the Shaarli version in the footer #125
Comments
Mildly related to #124 as the server version is displayed there, too (not yet in Material). |
I'm not sure to agree with this point. It doesn't violates the Semver scheme from my point of view. I don't consider the v is part of the version number itself. I just use it as a marker to indicate that what follows is the version number (even though it might seem obvious). Of course vdev looks weird but it's initially not intended to appear on a production version. I agree that it's an issue for people who update their installation with I'll think about this, but thanks for your feedback :) |
I see, thanks for the thought behind it! I can completely accept it if you're optimizing for the latest release and not the master branch. (However, sooner or later we will even have va38d25, v12abcd, and so on versions on the master branch, those will be fun 😃 shaarli/Shaarli#1676 ) As a last resort, one can delete the How about a config param that is set to |
The v prefix in the footer in front of the Shaarli version looks veird on the master branch build (vdev) and also violates the Semver scheme as it only consists of the X.X.X numbers.
The default Shaarli template also doesn't have the v prefix there, please delete it :)
The text was updated successfully, but these errors were encountered: